Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reset work for crio #6812

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Make reset work for crio #6812

merged 1 commit into from
Oct 12, 2020
+19 −8

Conversation

hafe
Copy link
Contributor

@hafe hafe commented Oct 10, 2020

crio refuses to delete pods when cni is unavailable which is the
case e.g. using calico with kdd datastore. See:

cri-o/cri-o#4084

Fix by deleting storage associated with containers. Stop and disable
crio service so switching container runtime can be done.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2020
@k8s-ci-robot k8s-ci-robot requested a review from bozzo October 10, 2020 12:08
@k8s-ci-robot
Copy link
Contributor

Hi @hafe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from oomichi October 10, 2020 12:08
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Oct 11, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2020
@floryut
Copy link
Member

floryut commented Oct 12, 2020

/approve
Looks a bit blunt to me but if this is required for cri-o then 🤷

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, hafe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2020
@hafe
Copy link
Contributor Author

hafe commented Oct 12, 2020

/approve
Looks a bit blunt to me but if this is required for cri-o then 🤷

Agree but this is what I need to do to iterate deploys. I think exactly the same problem exist for containerd

@hafe
Make reset work for crio
d941b63 
crio refuses to delete pods when cni is unavailable which is the
case e.g. using calico with kdd datastore. See:

cri-o/cri-o#4084

Fix by deleting storage associated with containers. Stop and disable
crio service so switching container runtime can be done.
@hafe
Copy link
Contributor Author

hafe commented Oct 12, 2020

Cleaner version after discussion with crio maintainer in slack. Keeps images which is good

@floryut
Copy link
Member

floryut commented Oct 12, 2020

Cleaner version after discussion with crio maintainer in slack. Keeps images which is good

Ok looks cleaner indeed 👍

@oomichi
Copy link
Contributor

oomichi commented Oct 12, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit e6effb8 into kubernetes-sigs:master Oct 12, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Oct 13, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
49b541f 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  change owner to root for bin_dir directory (kubernetes-sigs#6814)
  Modify imagepullpolicy (kubernetes-sigs#6816)
  fix: add tags for set facts nodelocaldns (kubernetes-sigs#6813)
  Make reset work for crio (kubernetes-sigs#6812)
  Added option to force apiserver and respective client certificate to … (kubernetes-sigs#6403)
  cleanup kubelet_deployment_type (kubernetes-sigs#6815)
  allow pre-existing floating IPs to be specified with k8s_master_fips (kubernetes-sigs#6755)
  Fix line-spacing in no_proxy.yml (kubernetes-sigs#6810)
  Fix handler naming issue for Kubeadm | kubelet (kubernetes-sigs#6803)
  Disable dashboard by default (kubernetes-sigs#6804)
  Chmod kubeconfig to avoid group-readable (kubernetes-sigs#6800)
  Update bunch of dependencies (kubernetes-sigs#6801)
  If no_proxy_exclude_workers is true, workers will be excluded from the no_proxy variable.  This prevents docker engine restarting when scaling workers. (kubernetes-sigs#6520)
@floryut floryut mentioned this pull request Dec 19, 2020
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@hafe @LuckySB
Make reset work for crio (kubernetes-sigs#6812)
d7b303a 
crio refuses to delete pods when cni is unavailable which is the
case e.g. using calico with kdd datastore. See:

cri-o/cri-o#4084

Fix by deleting storage associated with containers. Stop and disable
crio service so switching container runtime can be done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hafe @k8s-ci-robot @LuckySB @floryut @oomichi